Skip to content

Esql - Support date nanos in date extract function #120727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 27, 2025
Merged

Esql - Support date nanos in date extract function #120727

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
70a6fea
support date nanos in date extract
not-napoleon Jan 23, 2025
ba9c0ca
Update docs/changelog/120727.yaml
not-napoleon Jan 23, 2025
9319c3f
[CI] Auto commit changes from spotless
Jan 23, 2025
0cf6855
Merge branch 'main' into esql-date-nanos-date-extract
not-napoleon Jan 24, 2025
c9b965b
Merge branch 'main' into esql-date-nanos-date-extract
ivancea Jan 27, 2025
8152574
Refactor toEvaluator
ivancea Jan 27, 2025
06b91e1
Change TypeResolution error message to show date_nanos
ivancea Jan 27, 2025
a460257
Refactor test
ivancea Jan 27, 2025
c98a23a
Reuse methods in EsqlDataTypeConverter
ivancea Jan 27, 2025
e802368
[CI] Auto commit changes from spotless
Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changelog/120727.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
pr: 120727
summary: Esql - Support date nanos in date extract function
area: ES|QL
type: enhancement
issues:
- 110000
36 changes: 36 additions & 0 deletions docs/reference/esql/functions/kibana/definition/date_extract.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions docs/reference/esql/functions/types/date_extract.asciidoc
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/date_nanos.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,27 @@ millis:date | nanos:date_nanos | num:long
2023-10-23T12:15:03.360Z | 2023-10-23T12:15:03.360103847Z | 1698063303360103847
;

Date nanos date extract
required_capability: date_nanos_date_extract

FROM date_nanos
| EVAL nn = MV_MAX(nanos)
| EVAL year = DATE_EXTRACT("year", nn), ns = DATE_EXTRACT("nano_of_second", nn)
| KEEP nn, year, ns;

nn:date_nanos | year:long | ns:long
2023-10-23T13:55:01.543123456Z | 2023 | 543123456
2023-10-23T13:53:55.832987654Z | 2023 | 832987654
2023-10-23T13:52:55.015787878Z | 2023 | 015787878
2023-10-23T13:51:54.732102837Z | 2023 | 732102837
2023-10-23T13:33:34.937193000Z | 2023 | 937193000
2023-10-23T12:27:28.948000000Z | 2023 | 948000000
2023-10-23T12:15:03.360103847Z | 2023 | 360103847
2023-10-23T12:15:03.360103847Z | 2023 | 360103847
2023-03-23T12:15:03.360103847Z | 2023 | 360103847
2023-03-23T12:15:03.360103847Z | 2023 | 360103847
;

date nanos to long, index version
required_capability: to_date_nanos

Expand Down
137 changes: 137 additions & 0 deletions ...search/xpack/esql/expression/function/scalar/date/DateExtractConstantMillisEvaluator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

137 changes: 137 additions & 0 deletions ...csearch/xpack/esql/expression/function/scalar/date/DateExtractConstantNanosEvaluator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading