EsExecutor bug with empty core #120750
Closed
EsExecutor bug with empty core #120750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
reviewed
Jan 31, 2025
| // If a min of 0 is requested we set the thread core count to 1, but we allow the thread cores to timeout. | ||
| // This way we still achieve the goal of having 0 threads when idle, but we do not run into the risk of running into a case | ||
| // where we have task(s) in the queue and no worker to consume them. | ||
| corePoolSize = 1; |
DaveCTurner
reviewed
Jan 31, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
IMO if we're just going to do this workaround it'd be less trappy to just reject an invalid config instead of quietly fixing it up as proposed here.
Contributor
|
Hey @DaveCTurner , thanks for chiming in. |
Contributor
|
Yep, that's my contribution to that discussion :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.