Skip to content

ESQL: Fix DateExtract with nanos tests #120929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
Merged

ESQL: Fix DateExtract with nanos tests #120929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion x-pack/plugin/esql/qa/testFixtures/src/main/resources/date_nanos.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,8 @@ required_capability: date_nanos_date_extract
FROM date_nanos
| EVAL nn = MV_MAX(nanos)
| EVAL year = DATE_EXTRACT("year", nn), ns = DATE_EXTRACT("nano_of_second", nn)
| KEEP nn, year, ns;
| KEEP nn, year, ns
| SORT nn DESC;

nn:date_nanos | year:long | ns:long
2023-10-23T13:55:01.543123456Z | 2023 | 543123456
Expand Down
4 changes: 2 additions & 2 deletions ...c/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/date/DateExtract.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ public String getWriteableName() {
@Override
public ExpressionEvaluator.Factory toEvaluator(ToEvaluator toEvaluator) {
boolean isNanos = switch (field().dataType()) {
case DataType.DATETIME -> false;
case DataType.DATE_NANOS -> true;
case DATETIME -> false;
case DATE_NANOS -> true;
default -> throw new UnsupportedOperationException(
"Unsupported field type ["
+ field().dataType().name()
Expand Down