Revert "Add http stream content size handler (#120246)" #120934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 43e3e24.
ldematte
added
>non-issue
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
approved these changes
Jan 27, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Approving as a clean revert.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Tim-Brooks
pushed a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Jan 27, 2025
…ic#120934) This reverts commit 43e3e24.
Contributor
|
Backport opened here: #120953 |
Contributor
|
There was a minor merge conflict in Netty4IncrementalRequestHandlingIT related to the max context length constant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 43e3e24.
Incident 1077: The Elasticsearch-serverless build has been failing for over a week as the kibana e2e tests are failing
There is a suspected issue in the elasticsearch-js client: if the client does not use Expect: 100-continue header, Elasticsearch expects to be able to reject a request with 413 Content Too Large and close the connection (without consuming the body), but it seems the client doesn't notice that the connection is closed and instead returns an EPIPE error to a subsequent request.
The likely cause has been identified in #120246; as part of the content size limit, a different handling has been introduced, which does not sit well with the elasticsearch-js client