Skip to content

Conversation

@thecoop
Copy link
Member

@thecoop thecoop commented Jan 27, 2025

Also update the minimum compatible version to something like what 8.18 will be. Several tests are removed that tested previous transport versions that will now never be observed on 9.0

@thecoop thecoop added the v9.0.0 label Jan 27, 2025
@thecoop thecoop added the :Core/Infra/Transport API Transport client API label Jan 28, 2025
@thecoop thecoop marked this pull request as ready for review January 30, 2025 10:31
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jan 30, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@UpdateForV9(owner = UpdateForV9.Owner.CORE_INFRA)
// This needs to be bumped to the 8.last
public static final TransportVersion MINIMUM_COMPATIBLE = V_7_17_0;
public static final TransportVersion MINIMUM_COMPATIBLE = BYTE_SIZE_VALUE_ALWAYS_USES_BYTES_1;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to be precise at this stage, it just needs to be a value that will be collapsed into whatever 8.18.0 uses, at some point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently the most recent version in the 8.x branch - will need to be updated to the final version in the 8.18 branch when 8.18.0 is cut, correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not, it doesn't have to be the exact version, just some version between that used by 8.17 and 8.18. This is because this will only actually see the versions that are used for the releases, so version.onOrAfter(MINIMUM_COMPATIBLE) will match, even if MINIMUM_COMPATIBLE is a few id numbers behind the actual version used for 8.18.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm honoured you chose my transport version, even if it's a dead version never encountered in production because it got reverted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what was deployed to serverless at the time - so the serverless tests pass

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop thecoop added the v9.0.1 label Jan 31, 2025
@thecoop thecoop merged commit c8b6d2f into elastic:main Feb 3, 2025
17 checks passed
thecoop added a commit that referenced this pull request Feb 3, 2025
Also bump the minimum compatible version to something similar to what 8.18 will be
@thecoop thecoop deleted the 9.0-transport-version branch February 3, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Transport API Transport client API >non-issue Team:Core/Infra Meta label for core/infra team v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants