-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Create transport version for 9.0 release #120936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
| @UpdateForV9(owner = UpdateForV9.Owner.CORE_INFRA) | ||
| // This needs to be bumped to the 8.last | ||
| public static final TransportVersion MINIMUM_COMPATIBLE = V_7_17_0; | ||
| public static final TransportVersion MINIMUM_COMPATIBLE = BYTE_SIZE_VALUE_ALWAYS_USES_BYTES_1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need to be precise at this stage, it just needs to be a value that will be collapsed into whatever 8.18.0 uses, at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently the most recent version in the 8.x branch - will need to be updated to the final version in the 8.18 branch when 8.18.0 is cut, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually not, it doesn't have to be the exact version, just some version between that used by 8.17 and 8.18. This is because this will only actually see the versions that are used for the releases, so version.onOrAfter(MINIMUM_COMPATIBLE) will match, even if MINIMUM_COMPATIBLE is a few id numbers behind the actual version used for 8.18.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm honoured you chose my transport version, even if it's a dead version never encountered in production because it got reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's what was deployed to serverless at the time - so the serverless tests pass
rjernst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also update the minimum compatible version to something like what 8.18 will be. Several tests are removed that tested previous transport versions that will now never be observed on 9.0