Introduce AllocationBalancingRoundSummaryService #120957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiannaHohensee
added
>enhancement
:Distributed Coordination/Allocation
This service is added to the desired balance allocator to track and report on balancer round activity. It is a WIP and currently only tracks the number of shard moves caused by a balancing round. Reporting balancer round summary results will provide information with which to do cost-benefit analyses of the work that shard allocation rebalancing executes.
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DiannaHohensee
force-pushed
the
2025/01/17/ES-10341-computation-metrics-pr
branch
from
4e0b59f to
42103ca
Compare
Collaborator
|
Hi @DiannaHohensee, I've created a changelog YAML for you. |
DiannaHohensee
requested review from
nicktindall and
pxsalehi
and removed request for
a team
nicktindall
reviewed
Jan 28, 2025
| public static final Setting<TimeValue> BALANCER_ROUND_SUMMARIES_LOG_INTERVAL_SETTING = Setting.timeSetting( | ||
| "cluster.routing.allocation.desired_balance.balanace_round_summaries_interval", | ||
| TimeValue.timeValueSeconds(10), | ||
| TimeValue.ZERO, |
Contributor
There was a problem hiding this comment.
It says above
If less than zero, effectively disables reporting.
but the minimum is zero (I think?)
Either comment or code is out of date I think
nicktindall
approved these changes
Jan 28, 2025
...asticsearch/cluster/routing/allocation/allocator/AllocationBalancingRoundSummaryService.java
Outdated
Show resolved
Hide resolved
...search/cluster/routing/allocation/allocator/AllocationBalancingRoundSummaryServiceTests.java
Show resolved
Hide resolved
...search/cluster/routing/allocation/allocator/AllocationBalancingRoundSummaryServiceTests.java
Show resolved
Hide resolved
...search/cluster/routing/allocation/allocator/AllocationBalancingRoundSummaryServiceTests.java
Show resolved
Hide resolved
...search/cluster/routing/allocation/allocator/AllocationBalancingRoundSummaryServiceTests.java
Outdated
Show resolved
Hide resolved
...asticsearch/cluster/routing/allocation/allocator/AllocationBalancingRoundSummaryService.java
Outdated
Show resolved
Hide resolved
DiannaHohensee
commented
Jan 31, 2025
Contributor
Author
DiannaHohensee
left a comment
DiannaHohensee
left a comment
There was a problem hiding this comment.
Thanks for catching the details @nicktindall
...search/cluster/routing/allocation/allocator/AllocationBalancingRoundSummaryServiceTests.java
Show resolved
Hide resolved
...search/cluster/routing/allocation/allocator/AllocationBalancingRoundSummaryServiceTests.java
Show resolved
Hide resolved
...search/cluster/routing/allocation/allocator/AllocationBalancingRoundSummaryServiceTests.java
Show resolved
Hide resolved
nicktindall
approved these changes
Feb 2, 2025
...search/cluster/routing/allocation/allocator/AllocationBalancingRoundSummaryServiceTests.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This service is added to the desired balance allocator to track and
report on balancer round activity. It is a WIP and currently only
tracks the number of shard moves caused by a balancing round.
Reporting balancer round summary results will provide information
with which to do cost-benefit analyses of the work that shard
allocation rebalancing executes. It is disabled by default.
Relates ES-10341