Skip to content

Conversation

GalLalouche
Copy link
Contributor

@GalLalouche GalLalouche commented Jan 27, 2025

Following in the same vein as #119678 and #119945, this PR moves the errors tests in the numeric package to their own class.

43,303 tests -> 34,521 tests
6m 30s       -> 5m 50s

@GalLalouche GalLalouche added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.0 v8.18.0 labels Jan 27, 2025
@GalLalouche GalLalouche requested a review from nik9000 January 27, 2025 21:01
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy

@GalLalouche GalLalouche enabled auto-merge (squash) January 27, 2025 21:44
@GalLalouche GalLalouche merged commit f7ee67e into elastic:main Jan 27, 2025
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

GalLalouche added a commit to GalLalouche/elasticsearch that referenced this pull request Jan 27, 2025
Following in the same vein as elastic#119678 and elastic#119945, this PR moves the errors tests in the numeric package to their own class.

43,303 tests -> 34,521 tests
6m 30s       -> 5m 50s
GalLalouche added a commit to GalLalouche/elasticsearch that referenced this pull request Jan 28, 2025
Following in the same vein as elastic#119678 and elastic#119945, this PR moves the errors tests in the numeric package to their own class.

43,303 tests -> 34,521 tests
6m 30s       -> 5m 50s
GalLalouche added a commit to GalLalouche/elasticsearch that referenced this pull request Jan 28, 2025
Following in the same vein as elastic#119678 and elastic#119945, this PR moves the errors tests in the numeric package to their own class.

43,303 tests -> 34,521 tests
6m 30s       -> 5m 50s
elasticsearchmachine pushed a commit that referenced this pull request Jan 28, 2025
Following in the same vein as #119678 and #119945, this PR moves the errors tests in the numeric package to their own class.

43,303 tests -> 34,521 tests
6m 30s       -> 5m 50s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants