Skip to content

Fix syntax errors in the rescore retriever example #121024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix syntax errors in the rescore retriever example #121024

merged 1 commit into from
Jan 29, 2025

Conversation

@pstrsr
Copy link
Contributor

@pstrsr pstrsr commented Jan 28, 2025 •
edited by peter-strsr
Loading

I have tried the rescore retriever on serverless and the example in the documentation contains some minor syntax errors.

  1. window_size is part of the rescore object and not the rescore.query
  2. query is missing the script_score query, which causes it to fail.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team v9.0.0 labels Jan 28, 2025
@kingherc kingherc added :ml Machine learning >docs General docs changes labels Jan 29, 2025
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:ML Meta label for the ML team and removed needs:triage Requires assignment of a team area label labels Jan 29, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 29, 2025

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 29, 2025

Pinging @elastic/es-docs (Team:Docs)

@leemthompo leemthompo requested a review from pmpailis January 29, 2025 14:10
@leemthompo leemthompo added auto-backport Automatically create backport pull requests when merged v8.18.0 labels Jan 29, 2025
@leemthompo leemthompo self-assigned this Jan 29, 2025
@leemthompo
Copy link
Contributor

leemthompo commented Jan 29, 2025

run docs-build

@leemthompo
Copy link
Contributor

leemthompo commented Jan 29, 2025

@elasticmachine test this

pmpailis
pmpailis approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@pmpailis pmpailis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leemthompo
Copy link
Contributor

leemthompo commented Jan 29, 2025

Thanks for fixing the docs @pstrsr!

@leemthompo leemthompo merged commit 6b76457 into elastic:main Jan 29, 2025
8 checks passed
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 29, 2025
@pstrsr @leemthompo
Fix syntax errors in the rescore retriever example (elastic#121024)
73f6237
@leemthompo leemthompo mentioned this pull request Jan 29, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 29, 2025

💚 Backport successful

Status Branch Result
✅ 8.x

elasticsearchmachine pushed a commit that referenced this pull request Jan 29, 2025
@leemthompo @pstrsr
Fix syntax errors in the rescore retriever example (#121024) (#121195)
e227dd0 
Co-authored-by: Peter Straßer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmpailis pmpailis pmpailis approved these changes

Assignees

@leemthompo leemthompo

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team :ml Machine learning Team:Docs Meta label for docs team Team:ML Meta label for the ML team v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pstrsr @elasticsearchmachine @leemthompo @pmpailis @kingherc