Entitlements for thread properties #121094
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
force-pushed
the
entitlements-thread-properties
branch
from
b222ffc to
b639b0f
Compare
prdoyle
force-pushed
the
entitlements-thread-properties
branch
from
b639b0f to
0134a93
Compare
prdoyle
commented
Feb 6, 2025
| SetThreadContextClassLoaderEntitlement.class, | ||
| SetThreadPropertyEntitlement.class, | ||
| WriteAllSystemPropertiesEntitlement.class, | ||
| WriteSystemPropertiesEntitlement.class |
prdoyle
force-pushed
the
entitlements-thread-properties
branch
from
9211e23 to
db8131c
Compare
prdoyle
force-pushed
the
entitlements-thread-properties
branch
from
fcfb2d4 to
39fb3ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds five entitlements:
create_thread. Added toThreadconstructors. (This one is debatable, partly because we're not sure we want to instrumentThreadcreation at all, and partly because even if we do, the constructors don't create the thread: that's done byThread.start().)interrupt_threadset_thread_context_class_loader. This is the only one of the thread properties that's set by a plugin (namelyrepository-hdfs).set_thread_property. This is for all other sensitive thread properties, like name and priority.ThreadGroup.interrupt().See ES-10358.