Mark bbq indices as GA and add rolling upgrade integration tests #121105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>feature
auto-backport
Contributor
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Hi @benwtrent, I've created a changelog YAML for you. |
|
|
||
| NOTE: `int4` quantization requires an even number of vector dimensions. | ||
|
|
||
| NOTE: experimental:[] `bbq` quantization only supports vector dimensions that are greater than 64. |
Contributor
There was a problem hiding this comment.
missed an experimental marker on line 180
john-wagster
approved these changes
Jan 28, 2025
Contributor
john-wagster
left a comment
john-wagster
left a comment
There was a problem hiding this comment.
other than the 1 comment i left this LGTM
carlosdelest
approved these changes
Jan 29, 2025
Member
carlosdelest
left a comment
carlosdelest
left a comment
There was a problem hiding this comment.
This LGTM.
I guess rescore_vector should be kept as tech preview, correct? Otherwise we need to change that in the docs
benwtrent
added
the
auto-merge-without-approval
Collaborator
💚 Backport successful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of our new backing algorithm and making rescoring easier with the
rescore_vectorAPI, let's mark bbq as GA.Additionally, this commit adds rolling upgrade tests to ensure stability.