Rename AggregateDoubleMetric to *MetricDouble #121254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some areas of the code call this field type AggregateDoubleMetric and others AggregateMetricDouble, but the docs use aggregate_metric_double, so for consistency this commit refactors the former into the latter.
limotova
force-pushed
the
refactor-aggregate-metric-double-for-consistency
branch
from
cfb4fc6 to
d50dca1
Compare
martijnvg
approved these changes
Feb 3, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM 👍
Let's also backport this to 8.x, 9.0 and 8.18 branch? This makes back porting easier.
limotova
added
the
auto-backport
elasticsearchmachine
added
the
needs:triage
martijnvg
added
>non-issue
:StorageEngine/Downsampling
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
limotova
added a commit
to limotova/elasticsearch
that referenced
this pull request
Feb 4, 2025
Some areas of the code call this field type AggregateDoubleMetric and others AggregateMetricDouble, but the docs use aggregate_metric_double, so for consistency this commit refactors the former into the latter.
This was referenced Feb 4, 2025
limotova
added a commit
to limotova/elasticsearch
that referenced
this pull request
Feb 4, 2025
Some areas of the code call this field type AggregateDoubleMetric and others AggregateMetricDouble, but the docs use aggregate_metric_double, so for consistency this commit refactors the former into the latter.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some areas of the code call this field type
AggregateDoubleMetric and others AggregateMetricDouble, but the docs
use aggregate_metric_double, so for consistency this commit refactors
the former into the latter.