Skip to content

Conversation

@mhl-b
Copy link
Contributor

@mhl-b mhl-b commented Jan 30, 2025

Backport #121095. Diff is smaller than main because original PR was reverted on main, but not in 8.x

Fix. In original PR requests without Expect: 100-Continue and oversized are rejected with subsequent channel closure. This is not what netty does and introduced breakage on elasticsearch-js client. The expected behaviour is that ES should reject request and discard body without closing connection.

@mhl-b mhl-b added >non-issue :Distributed Coordination/Network Http and internode communication implementations backport Team:Distributed Coordination Meta label for Distributed Coordination team v8.18.0 auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Jan 30, 2025
@elasticsearchmachine elasticsearchmachine merged commit 5b6bef5 into elastic:8.x Jan 30, 2025
15 checks passed
@mhl-b mhl-b deleted the backport-http-stream-content-size-2 branch January 30, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Coordination/Network Http and internode communication implementations >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team v8.18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants