Fix privileges for system index migration WRITE block #121329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic#121120)" This reverts commit e27a1ec.
…x-priveledges-in-system-migration-block-8x
elasticsearchmachine
added
Team:Core/Infra
JVerwolf
changed the title
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @JVerwolf, I've created a changelog YAML for you. |
…x-priveledges-in-system-migration-block-8x
… github.com:JVerwolf/elasticsearch into bugfix/fix-priveledges-in-system-migration-block-8x
|
@elasticmachine update branch |
… github.com:JVerwolf/elasticsearch into bugfix/fix-priveledges-in-system-migration-block-8x
JVerwolf
added
the
auto-merge-without-approval
|
@elasticmachine update branch |
JVerwolf
deleted the
bugfix/fix-priveledges-in-system-migration-block-8x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #121120 with a fix for #120566, which was causing the system index migration service to fail when security was enabled.
This PR removes a potential cause of data loss when migrating system indices. It does this by changing the way we set a "write-block" on the system index to migrate - now using a dedicated transport request rather than a settings update. Furthermore, we no longer delete the write-block prior to deleting the index, as this was another source of potential data loss. Additionally, we now remove the block if the migration fails.
This is a backport of #121327
Jira: ES-9724