Add length limit FileSettingsHealthIndicatorService.description #121334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
commented
Jan 30, 2025
| private String limitLength(String description) { | ||
| int descriptionLengthLimit = DESCRIPTION_LENGTH_LIMIT.get(settings); | ||
| if (description.length() > descriptionLengthLimit) { | ||
| return description.substring(0, descriptionLengthLimit - 1) + "…"; |
Contributor
Author
There was a problem hiding this comment.
Note that this is an ellipsis character, not three periods.
JVerwolf
approved these changes
Jan 31, 2025
Contributor
JVerwolf
left a comment
JVerwolf
left a comment
There was a problem hiding this comment.
Overall LGTM. Had a few questions/thoughts to optionally address.
server/src/main/java/org/elasticsearch/reservedstate/service/FileSettingsService.java
Show resolved
Hide resolved
...st/java/org/elasticsearch/reservedstate/service/FileSettingsHealthIndicatorServiceTests.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/reservedstate/service/FileSettingsService.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReservedClusterStateServicesometimes throws anIllegalArgumentExceptionwith a hugedescriptionfield containing a complete stack trace, like here, where it includes anErrorStatein the description, andErrorStateincludes the stack trace:The solution here is just to limit the length of the description. I've used a
Settingin case the default length limit turns out to be too short and it needs to be overridden in a hurry (ironically, usingFileSettingsService).See ES-10713.