[Inference API] Wait for rate limit assignments to happen in rate limit calculator tests #121379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
needs:triage
timgrein
changed the title
timgrein
commented
Jan 31, 2025
| @ESIntegTestCase.ClusterScope(scope = ESIntegTestCase.Scope.SUITE, numDataNodes = 0) | ||
| public class InferenceServiceNodeLocalRateLimitCalculatorTests extends ESIntegTestCase { | ||
|
|
||
| private static final Integer RATE_LIMIT_ASSIGNMENT_MAX_WAIT_TIME_IN_SECONDS = 15; |
Contributor
Author
There was a problem hiding this comment.
This is only used once, but I wanted to make it obvious that we've a timeout used throughout this class. Therefore I've put it at the top as a constant.
elasticsearchmachine
removed
the
needs:triage
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
approved these changes
Jan 31, 2025
timgrein
added
the
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121294
ensureStableClusterdoesn't guarantee that the nodes already processed the rate limit assignments, but only guarantees that each node:Therefore we need to wait (set the timeout to 15 seconds to begin with), which should give each node/calculator enough time to process the topology change and calculate the rate limit assignments. This is a pattern I saw throughout the whole ES codebase (using
assertBusy(() -> {...})).