Skip to content

Conversation

@benwtrent
Copy link
Member

This simplifies the setup and relaxes the similarity check.

We can restrict the similarity check once we evolve the quantization algorithm in the future.

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :Search Relevance/Vectors Vector search v9.0.0 v8.18.1 v8.19.0 v9.1.0 labels Jan 31, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jan 31, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

index: int4_flat
- do:
indices.refresh: {}
- do:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ merge after flush, this covers us fine. Removing unnecessary merge.

@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 31, 2025
@elasticsearchmachine elasticsearchmachine merged commit 2de1a3d into elastic:main Feb 4, 2025
17 checks passed
@benwtrent benwtrent deleted the test/relax-int4-flat-test branch February 4, 2025 22:35
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.0 Commit could not be cherrypicked due to conflicts
8.18 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 121437

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Feb 5, 2025
This simplifies the setup and relaxes the similarity check.

We can restrict the similarity check once we evolve the quantization
algorithm in the future.

(cherry picked from commit 2de1a3d)
@benwtrent
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x
9.0
8.18

Questions ?

Please refer to the Backport tool documentation

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Feb 5, 2025
This simplifies the setup and relaxes the similarity check.

We can restrict the similarity check once we evolve the quantization
algorithm in the future.

(cherry picked from commit 2de1a3d)
elasticsearchmachine pushed a commit that referenced this pull request Feb 5, 2025
This simplifies the setup and relaxes the similarity check.

We can restrict the similarity check once we evolve the quantization
algorithm in the future.

(cherry picked from commit 2de1a3d)
elasticsearchmachine pushed a commit that referenced this pull request Feb 5, 2025
This simplifies the setup and relaxes the similarity check.

We can restrict the similarity check once we evolve the quantization
algorithm in the future.

(cherry picked from commit 2de1a3d)
benwtrent added a commit that referenced this pull request Feb 5, 2025
This simplifies the setup and relaxes the similarity check.

We can restrict the similarity check once we evolve the quantization
algorithm in the future.

(cherry picked from commit 2de1a3d)
@benwtrent
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.17

Questions ?

Please refer to the Backport tool documentation

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Feb 13, 2025
This simplifies the setup and relaxes the similarity check.

We can restrict the similarity check once we evolve the quantization
algorithm in the future.

(cherry picked from commit 2de1a3d)
elasticsearchmachine pushed a commit that referenced this pull request Feb 13, 2025
This simplifies the setup and relaxes the similarity check.

We can restrict the similarity check once we evolve the quantization
algorithm in the future.

(cherry picked from commit 2de1a3d)
elasticsearchmachine pushed a commit that referenced this pull request Feb 13, 2025
This test was missed back in my "fix int4" PR. 

#121437

closes: #121412
elasticsearchmachine pushed a commit that referenced this pull request Feb 14, 2025
This test was missed back in my "fix int4" PR.

#121437

closes: #121412
(cherry picked from commit 4bba2ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants