[TEST] wait for all active shards when indexing data #121442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attempts to fix a flay test where the term_freq returned by the multiple terms vectors API was `null`. I was not able to reproduce this test but this proposes a fix based on the following running theory: - an Elasticsearch cluster comprised of at least 2 nodes - we create a couple of indices with 1 primary and 1 replica - we index a document that was acknowledged only by the primary (because `wait_for_active_shards` defaults to `1`) - the test executes the multiple terms vectors API and it hits the node hosting the replica shard, which hasn't yet received the document we ingested in the primary shard. This race condition between the document replication and the test running the terms vectors API on the replica shard could yield a `null` value for the the term's `term_freq` (as the replica shard contains 0 documents). This PR proposes we change the `wait_for_active_shards` value to `all` so each write is acknowledged by all replicas before the client receives the response.
andreidan
added
>test-failure
elasticsearchmachine
added
needs:risk
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
piergm
approved these changes
Jan 31, 2025
Member
piergm
left a comment
piergm
left a comment
There was a problem hiding this comment.
Theory make sense to me! More so if it's not always failing but a flaky test 😄 Nice one Andrei! Let's hope the theory is correct 🤞
Contributor
Author
|
@elasticmachine update branch |
andreidan
added
auto-merge-without-approval
elasticsearchmachine
added
the
needs:risk
andreidan
added
low-risk
Contributor
Author
|
@elasticmachine update branch |
andreidan
added
the
auto-backport
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix a flay test where the term_freq returned by the multiple terms vectors API was
null.I was not able to reproduce this test but this proposes a fix based on the following running theory:
wait_for_active_shardsdefaults to1)This race condition between the document replication and the test running the terms vectors API on the replica shard could yield a
nullvalue for the the term'sterm_freq(as the replica shard contains 0 documents).This PR proposes we change the
wait_for_active_shardsvalue toallso each write is acknowledged by all replicas before the client receives the response.Fixes #113325