Change PolicyManager so pluginResolver overrides agent settings #121456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Feb 3, 2025
This was referenced Feb 3, 2025
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Feb 3, 2025
Collaborator
Closed
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
pluginResolverfunction returns a non-null plugin name, that means the class comes from a plugin, and so under no circumstances should we be falling back to the (more permissive) agent policy, which the current logic does if the plugin doesn't have its own policy.