Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,14 @@ private FieldValues<Geometry> scriptValues() {
@Override
public GeoShapeWithDocValuesFieldMapper build(MapperBuilderContext context) {
if (multiFieldsBuilder.hasMultiFields()) {
/*
* We have no plans to fail on multifields because it isn't worth breaking
* even the tiny fraction of users.
*/
DEPRECATION_LOGGER.warn(
DeprecationCategory.MAPPINGS,
"geo_shape_multifields",
"Adding multifields to [geo_shape] mappers has no effect and will be forbidden in future"
"Adding multifields to [geo_shape] mappers has no effect"
);
}
GeometryParser geometryParser = new GeometryParser(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,14 @@ private static CartesianPoint parseNullValue(Object nullValue, boolean ignoreZVa
@Override
public FieldMapper build(MapperBuilderContext context) {
if (multiFieldsBuilder.hasMultiFields()) {
/*
* We have no plans to fail on multifields because it isn't worth breaking
* even the tiny fraction of users.
*/
DEPRECATION_LOGGER.warn(
DeprecationCategory.MAPPINGS,
"point_multifields",
"Adding multifields to [point] mappers has no effect and will be forbidden in future"
"Adding multifields to [point] mappers has no effect"
);
}
CartesianPointParser parser = new CartesianPointParser(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,14 @@ protected Parameter<?>[] getParameters() {
@Override
public ShapeFieldMapper build(MapperBuilderContext context) {
if (multiFieldsBuilder.hasMultiFields()) {
/*
* We have no plans to fail on multifields because it isn't worth breaking
* even the tiny fraction of users.
*/
DEPRECATION_LOGGER.warn(
DeprecationCategory.MAPPINGS,
"shape_multifields",
"Adding multifields to [shape] mappers has no effect and will be forbidden in future"
"Adding multifields to [shape] mappers has no effect"
);
}
GeometryParser geometryParser = new GeometryParser(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ public void testMultiFieldsDeprecationWarning() throws Exception {
b.startObject("keyword").field("type", "keyword").endObject();
b.endObject();
}));
assertWarnings("Adding multifields to [" + getFieldName() + "] mappers has no effect and will be forbidden in future");
assertWarnings("Adding multifields to [" + getFieldName() + "] mappers has no effect");
}

public void testSelfIntersectPolygon() throws IOException {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ public void testMultiFieldsDeprecationWarning() throws Exception {
b.startObject("keyword").field("type", "keyword").endObject();
b.endObject();
}));
assertWarnings("Adding multifields to [point] mappers has no effect and will be forbidden in future");
assertWarnings("Adding multifields to [point] mappers has no effect");
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ public void testMultiFieldsDeprecationWarning() throws Exception {
b.startObject("keyword").field("type", "keyword").endObject();
b.endObject();
}));
assertWarnings("Adding multifields to [" + getFieldName() + "] mappers has no effect and will be forbidden in future");
assertWarnings("Adding multifields to [" + getFieldName() + "] mappers has no effect");
}

public void testSelfIntersectPolygon() throws IOException {
Expand Down