Return failure store status on ingest failures for data streams without failure store enabled #121544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.1.0
needs:triage
jbaiera
added
:Data Management/Ingest Node
elasticsearchmachine
added
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
1 similar comment
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
jbaiera
requested review from
gmarouli and
nielsbauman
and removed request for
nielsbauman
Member
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Feb 21, 2025
…ut failure store enabled (elastic#121544) Updates the on failure handler to accept the additional context required to report to the client whether or not the document could have been rerouted if failure store was enabled. --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit 59fc383)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 21, 2025
… without failure store enabled (#121544) (#123170) * Return failure store status on ingest failures for data streams without failure store enabled (#121544) Updates the on failure handler to accept the additional context required to report to the client whether or not the document could have been rerouted if failure store was enabled. --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit 59fc383) * fix test compile --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ingest failure occurs against a data stream, if the data stream's failure store redirection is enabled it will capture the failure and report that the failure store was used in that document's response to the client. If the failure store is not enabled, we report to the client that we could have stored the failure but that we did not. There was a gap in this functionality in the ingest service: On a failure, if the document was determined to not go to the failure store, that context was discarded when the document was passed to the on failure handler. This PR updates the on failure handler to accept the additional context required to report to the client whether or not the document could have been rerouted if failure store was enabled or not.