Remove reflection tests from entitlements REST tests #121550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is best tested in unit tests, not REST actions.
prdoyle
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
This was referenced Feb 3, 2025
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Feb 3, 2025
This is best tested in unit tests, not REST actions.
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Feb 3, 2025
This is best tested in unit tests, not REST actions.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 3, 2025
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Feb 4, 2025
This is best tested in unit tests, not REST actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is best tested in unit tests, not REST actions.
It turns out we already test reflection by necessity for static methods here anyway.
This reverts part of #121436.