Fix counted_keyword support in arrays of objects #121558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-powers
added
>bug
auto-backport
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
lkts
approved these changes
Feb 4, 2025
Contributor
There was a problem hiding this comment.
LGTM and i think this is backwards compatible as well since doc values have the same format. @martijnvg do you see any problems with BWC here?
Member
Yes, I think this change doesn't break bwc. Since keep storing the values as single binary array (even though the values may have come from multiple array elements or leaf fields with the same name), so the format doesn't change. |
| @Override | ||
| public BytesRef binaryValue() { | ||
| try { | ||
| int bytesSize = (counts.size() + 1) * 5; |
Contributor
There was a problem hiding this comment.
Maybe use a constant with a meaningful name for 5?
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
As a result of the randomized testing enabled in #121462, we found that we currently fail to parse documents with arrays of objects containing counted_keyword fields. This PR fixes this issue by using a custom docvalues field to store the count instead of the built-in lucene BinaryDocValues. This custom CountsBinaryDocValuesField has logic to handle multiple values for the same field. (cherry picked from commit 13b743c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of the randomized testing enabled in #121462, we found that we currently fail to parse documents with arrays of objects containing counted_keyword fields.
For example, attempting to index this document with this mapping would produce an error:
Mapping:
Document:
{ "parent": [ {"child": "a"}, {"child": "b"} ] }Error:
"type":"illegal_argument_exception","reason":"DocValuesField \"parent.child_count\" appears more than once in this document (only one value is allowed per field)This PR fixes this issue by using a custom docvalues field to store the count instead of the built-in lucene
BinaryDocValues. This customCountsBinaryDocValuesFieldhas logic to handle multiple values for the same field.