-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Fix ClusterRequestTests #121570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix ClusterRequestTests #121570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
03b6697 to
179b558
Compare
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 3, 2025
The upper bound of randomVersionBetween is inclusive; therefore, for testing the fallback version of the request, we need to use the version preceding 8.16.0 rather than 8.16.0 itself. Closes elastic#117937
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 4, 2025
The upper bound of randomVersionBetween is inclusive; therefore, for testing the fallback version of the request, we need to use the version preceding 8.16.0 rather than 8.16.0 itself. Closes elastic#117937
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 4, 2025
The upper bound of randomVersionBetween is inclusive; therefore, for testing the fallback version of the request, we need to use the version preceding 8.16.0 rather than 8.16.0 itself. Closes elastic#117937
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 4, 2025
The upper bound of randomVersionBetween is inclusive; therefore, for testing the fallback version of the request, we need to use the version preceding 8.16.0 rather than 8.16.0 itself. Closes elastic#117937
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 4, 2025
The upper bound of randomVersionBetween is inclusive; therefore, for testing the fallback version of the request, we need to use the version preceding 8.16.0 rather than 8.16.0 itself. Closes elastic#117937
dnhatn
added a commit
that referenced
this pull request
Feb 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Feb 4, 2025
The upper bound of randomVersionBetween is inclusive; therefore, for testing the fallback version of the request, we need to use the version preceding 8.16.0 rather than 8.16.0 itself. Closes elastic#117937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
>test
Issues or PRs that are addressing/adding tests
v8.16.4
v8.17.2
v8.18.1
v8.19.0
v9.0.1
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upper bound of randomVersionBetween is inclusive; therefore, for
testing the fallback version of the request, we need to use the version
preceding 8.16.0 rather than 8.16.0 itself.
Closes #117937