Skip to content

Conversation

@brianseeders
Copy link
Contributor

  • Upgrades spotless to latest, which enables a bunch of new stuff, including the ability to sort members of classes
  • Commit the output of ./gradlew spotlessApply as well

@mhl-b
Copy link
Contributor

mhl-b commented Mar 6, 2025

Are you still planning to do this? Spotless breaks in switch pattern matching like this:

    switch (c) {
        case Suit s when s == Suit.CLUBS -> {
            System.out.println("It's clubs");
        }

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Mar 11, 2025
@brianseeders brianseeders marked this pull request as ready for review March 12, 2025 18:49
@brianseeders brianseeders requested a review from a team as a code owner March 12, 2025 18:49
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby
Copy link
Contributor

One thing we run into in the past with 7.0 beta versions was this: diffplug/spotless#2331
But seems that got fixed.

@joegallo
Copy link
Contributor

joegallo commented Apr 2, 2025

Closed in favor of #126125 which it turns out did basically all the same stuff. My bad!

@joegallo joegallo closed this Apr 2, 2025
@brianseeders
Copy link
Contributor Author

Nope, it's my bad for never merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Tooling Developer tooliing and automation >non-issue serverless-linked Added by automation, don't add manually Team:Delivery Meta label for Delivery team v8.16.7 v8.17.5 v8.18.0 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants