Skip to content

Conditionally use sequential stored field reader in LuceneSyntheticSourceChangesSnapshot #121636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 10, 2025
Merged

Conditionally use sequential stored field reader in LuceneSyntheticSourceChangesSnapshot #121636

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6eb67b2
Use sequential reader in LuceneSyntheticSourceChangesSnapshot
martijnvg Feb 4, 2025
41d4e68
iter
martijnvg Feb 4, 2025
8e9436c
added comment
martijnvg Feb 4, 2025
99623e7
Merge remote-tracking branch 'es/main' into LuceneSyntheticSourceChan…
martijnvg Feb 4, 2025
161a429
Merge remote-tracking branch 'es/main' into LuceneSyntheticSourceChan…
martijnvg Feb 6, 2025
1d0a210
pass down docids in order to determine whether to load sequential
martijnvg Feb 6, 2025
c6cc1e7
iter
martijnvg Feb 6, 2025
78f0b7e
iter2
martijnvg Feb 6, 2025
0f8dca1
Merge remote-tracking branch 'es/main' into LuceneSyntheticSourceChan…
martijnvg Feb 7, 2025
9a7a3e7
iter3
martijnvg Feb 7, 2025
447de83
Merge remote-tracking branch 'es/main' into LuceneSyntheticSourceChan…
martijnvg Feb 10, 2025
31b81c0
added comment
martijnvg Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...er/src/main/java/org/elasticsearch/index/engine/LuceneSyntheticSourceChangesSnapshot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import org.apache.lucene.util.ArrayUtil;
import org.elasticsearch.index.IndexSettings;
import org.elasticsearch.index.IndexVersion;
import org.elasticsearch.index.codec.CodecService;
import org.elasticsearch.index.fieldvisitor.LeafStoredFieldLoader;
import org.elasticsearch.index.fieldvisitor.StoredFieldLoader;
import org.elasticsearch.index.mapper.MapperService;
Expand Down Expand Up @@ -83,7 +84,9 @@ public LuceneSyntheticSourceChangesSnapshot(
this.maxMemorySizeInBytes = maxMemorySizeInBytes > 0 ? maxMemorySizeInBytes : 1;
this.sourceLoader = mapperService.mappingLookup().newSourceLoader(null, SourceFieldMetrics.NOOP);
Set<String> storedFields = sourceLoader.requiredStoredFields();
this.storedFieldLoader = StoredFieldLoader.create(false, storedFields);
String codec = EngineConfig.INDEX_CODEC_SETTING.get(mapperService.getIndexSettings().getSettings());
boolean shouldForceSequentialReader = CodecService.BEST_COMPRESSION_CODEC.equals(codec);
this.storedFieldLoader = StoredFieldLoader.create(false, storedFields, shouldForceSequentialReader);
Copy link
Member Author

@martijnvg martijnvg Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use always force a sequential reader. I think no matter the stored field format, it has benefits given how LuceneSyntheticSourceChangesSnapshot access stored fields.

Copy link
Contributor

@henningandersen henningandersen Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely sure. Does this not depend upon how jumpy the data is, which with index sorting could be very jumpy - and whether there is more than one stored field per doc (not sure that is always true?)?

Copy link
Member Author

@martijnvg martijnvg Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this is why then changed to logic not look at index.codec setting anymore.

this.lastSeenSeqNo = fromSeqNo - 1;
}

Expand Down