Remove redundant list copy in CanMatchNodeRequest #121700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not mutating that list ever, so lets just use an immutable list all the way here and avoid at least one round of needless copy.
original-brownbear
added
>non-issue
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
original-brownbear
added
auto-backport
|
Thanks Nhat! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 6, 2025
We're not mutating that list ever, so lets just use an immutable list all the way here and avoid at least one round of needless copy.
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 6, 2025
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Apr 4, 2025
We're not mutating that list ever, so lets just use an immutable list all the way here and avoid at least one round of needless copy.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random find: We're not mutating that list ever, so lets just use an immutable list all the way here and avoid at least one round of needless copy.