-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Validate transport handshake from known version #121747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 4 commits into
elastic:main
from
DaveCTurner:2025/02/05/validate-known-transport-handshake-version
Feb 5, 2025
Merged
Validate transport handshake from known version #121747
elasticsearchmachine
merged 4 commits into
elastic:main
from
DaveCTurner:2025/02/05/validate-known-transport-handshake-version
Feb 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9175d30 to
90fc6d3
Compare
With parallel releases on multiple branches it's possible that an older branch sees a transport version update that is not known to a numerically newer but chronologically older version. In that case the two nodes cannot intercommunicate, so with this commit we reject such connection attempts at the version negotiation stage.
8e786c1 to
f7003b5
Compare
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one suggestion
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 5, 2025
With parallel releases on multiple branches it's possible that an older branch sees a transport version update that is not known to a numerically newer but chronologically older version. In that case the two nodes cannot intercommunicate, so with this commit we reject such connection attempts at the version negotiation stage.
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 5, 2025
With parallel releases on multiple branches it's possible that an older branch sees a transport version update that is not known to a numerically newer but chronologically older version. In that case the two nodes cannot intercommunicate, so with this commit we reject such connection attempts at the version negotiation stage. Backport of elastic#121747 to 8.x
|
Working on the 8.x backport at #121802 |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 6, 2025
This test creates an incorrectly-serialized handshake which cannot be validated, and elastic#121747 made that validation compulsory. This test corrects the serialization. Closes 121816
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 6, 2025
This test creates an incorrectly-serialized handshake which cannot be validated, and elastic#121747 made that validation compulsory. This test corrects the serialization. Closes elastic#121816
DaveCTurner
added a commit
that referenced
this pull request
Feb 6, 2025
DaveCTurner
added a commit
that referenced
this pull request
Feb 6, 2025
DaveCTurner
added a commit
that referenced
this pull request
Feb 6, 2025
DaveCTurner
added a commit
that referenced
this pull request
Feb 6, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 6, 2025
) * Validate transport handshake from known version (#121747) With parallel releases on multiple branches it's possible that an older branch sees a transport version update that is not known to a numerically newer but chronologically older version. In that case the two nodes cannot intercommunicate, so with this commit we reject such connection attempts at the version negotiation stage. * Fix version/transportversion confusion * CI poke
DaveCTurner
added a commit
that referenced
this pull request
Feb 7, 2025
With parallel releases on multiple branches it's possible that an older branch sees a transport version update that is not known to a numerically newer but chronologically older version. In that case the two nodes cannot intercommunicate, so with this commit we reject such connection attempts at the version negotiation stage. Backport of #121747 to 8.x
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 7, 2025
With parallel releases on multiple branches it's possible that an older branch sees a transport version update that is not known to a numerically newer but chronologically older version. In that case the two nodes cannot intercommunicate, so with this commit we reject such connection attempts at the version negotiation stage. Backport of elastic#121747 to 8.x
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 7, 2025
With parallel releases on multiple branches it's possible that an older branch sees a transport version update that is not known to a numerically newer but chronologically older version. In that case the two nodes cannot intercommunicate, so with this commit we reject such connection attempts at the version negotiation stage. Backport of elastic#121747/elastic#121802 to 8.18
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
With parallel releases on multiple branches it's possible that an older branch sees a transport version update that is not known to a numerically newer but chronologically older version. In that case the two nodes cannot intercommunicate, so with this commit we reject such connection attempts at the version negotiation stage. Backport of #121747 to 8.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Core/Infra/Core
Core issues without another label
>non-issue
Team:Core/Infra
Meta label for core/infra team
v8.18.1
v8.19.0
v9.0.1
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With parallel releases on multiple branches it's possible that an older
branch sees a transport version update that is not known to a
numerically newer but chronologically older version. In that case the
two nodes cannot intercommunicate, so with this commit we reject such
connection attempts at the version negotiation stage.