Skip to content

Fix testLogsSlowInboundProcessing #121895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2025
Merged

Fix testLogsSlowInboundProcessing #121895

merged 1 commit into from
Feb 6, 2025

Conversation

@DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Feb 6, 2025

This test creates an incorrectly-serialized handshake which cannot be
validated, and #121747 made that validation compulsory. This test
corrects the serialization.

Closes #121816

@DaveCTurner
Fix testLogsSlowInboundProcessing
cbe5470 
This test creates an incorrectly-serialized handshake which cannot be
validated, and elastic#121747 made that validation compulsory. This test
corrects the serialization.

Closes elastic#121816
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.1 v8.19.0 v9.1.0 labels Feb 6, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 6, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 6, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

@DaveCTurner DaveCTurner mentioned this pull request Feb 6, 2025
Merged
JVerwolf
JVerwolf approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@JVerwolf JVerwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit 5537a51 into elastic:main Feb 6, 2025
17 checks passed
@DaveCTurner DaveCTurner deleted the 2025/02/06/fix-testLogsSlowInboundProcessing branch February 6, 2025 15:50
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 6, 2025

💔 Backport failed

Status Branch Result
❌ 9.0 Commit could not be cherrypicked due to conflicts
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 121895

DaveCTurner added a commit that referenced this pull request Feb 6, 2025
@DaveCTurner
Fix testLogsSlowInboundProcessing (#121895)
eea697e 
This test creates an incorrectly-serialized handshake which cannot be
validated, and #121747 made that validation compulsory. This test
corrects the serialization.

Closes #121816
DaveCTurner added a commit that referenced this pull request Feb 6, 2025
@DaveCTurner
Fix testLogsSlowInboundProcessing (#121895)
5c24d0b 
This test creates an incorrectly-serialized handshake which cannot be
validated, and #121747 made that validation compulsory. This test
corrects the serialization.

Closes #121816
DaveCTurner added a commit that referenced this pull request Feb 6, 2025
@DaveCTurner
Fix testLogsSlowInboundProcessing (#121895)
4e6e0d4 
This test creates an incorrectly-serialized handshake which cannot be
validated, and #121747 made that validation compulsory. This test
corrects the serialization.

Closes #121816
@DaveCTurner
Copy link
Contributor Author

DaveCTurner commented Feb 6, 2025

Backports:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JVerwolf JVerwolf JVerwolf approved these changes

@thecoop thecoop Awaiting requested review from thecoop

@pxsalehi pxsalehi Awaiting requested review from pxsalehi

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] InboundHandlerTests testLogsSlowInboundProcessing failing

3 participants

@DaveCTurner @elasticsearchmachine @JVerwolf