-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Updates to allow using Cohere binary embedding response in semantic search queries. #121827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o more-cohere-bits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @ymao1, I've created a changelog YAML for you. |
|
Waiting for @davidkyle to give a 👍 after running some validation tests. |
| : inference.length; | ||
| if (inferenceLength != modelSettings.dimensions()) { | ||
| throw new IllegalArgumentException( | ||
| generateDimensionCountMismatchMessage(inference.length, modelSettings.dimensions()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure to update this error message with the correct dimension count as well
|
Pinging @elastic/ml-core (Team:ML) |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…earch queries. (elastic#121827) * wip * wip * [CI] Auto commit changes from spotless * updating tests * [CI] Auto commit changes from spotless * Update docs/changelog/121827.yaml * Updates after the refactor * [CI] Auto commit changes from spotless * Updating error message --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit e843849) # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/InferenceTextEmbeddingBitResults.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/chunking/EmbeddingRequestChunkerTests.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…earch queries. (elastic#121827) * wip * wip * [CI] Auto commit changes from spotless * updating tests * [CI] Auto commit changes from spotless * Update docs/changelog/121827.yaml * Updates after the refactor * [CI] Auto commit changes from spotless * Updating error message --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit e843849) # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/TextEmbeddingBitResults.java
…ntic search queries. (#121827) (#123625) * Updates to allow using Cohere binary embedding response in semantic search queries. (#121827) * wip * wip * [CI] Auto commit changes from spotless * updating tests * [CI] Auto commit changes from spotless * Update docs/changelog/121827.yaml * Updates after the refactor * [CI] Auto commit changes from spotless * Updating error message --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit e843849) # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/TextEmbeddingBitResults.java * Fixing compile error
Summary
Updates to get semantic search working with bit embeddings.
Verify
Following the instructions in this tutorial:
This will verify that the process of using a inference endpoint with binary embedding works with semantic text queries.
Load data as directed by the the tutorial
Reindex the data