Use dynamic policy for entitled test plugin #121852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the plugin being testing, the entitled test plugin needs access to dynamic elements (namely, file paths). This commit dynamically generates the entitlement policy for the entitlted test plugin when it is installed. It also adds using the file entitltlement as an example.
rjernst
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
reviewed
Feb 7, 2025
| throw new UncheckedIOException(e); | ||
| } | ||
| }); | ||
| private void setupEntitlements(PluginInstallSpec spec, boolean modular, PolicyBuilder policyBuilder) { |
There was a problem hiding this comment.
The distinction between the names setupEntitlements and buildEntitlements is a bit subtle... but these are private helpers, so it's not too hard to just look at them and see what they do.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 7, 2025
Like the plugin being testing, the entitled test plugin needs access to dynamic elements (namely, file paths). This commit dynamically generates the entitlement policy for the entitlted test plugin when it is installed. It also adds using the file entitltlement as an example.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 7, 2025
Like the plugin being testing, the entitled test plugin needs access to dynamic elements (namely, file paths). This commit dynamically generates the entitlement policy for the entitlted test plugin when it is installed. It also adds using the file entitltlement as an example.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 7, 2025
Like the plugin being testing, the entitled test plugin needs access to dynamic elements (namely, file paths). This commit dynamically generates the entitlement policy for the entitlted test plugin when it is installed. It also adds using the file entitltlement as an example.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
Like the plugin being testing, the entitled test plugin needs access to dynamic elements (namely, file paths). This commit dynamically generates the entitlement policy for the entitlted test plugin when it is installed. It also adds using the file entitltlement as an example.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
Like the plugin being testing, the entitled test plugin needs access to dynamic elements (namely, file paths). This commit dynamically generates the entitlement policy for the entitlted test plugin when it is installed. It also adds using the file entitltlement as an example.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
Like the plugin being testing, the entitled test plugin needs access to dynamic elements (namely, file paths). This commit dynamically generates the entitlement policy for the entitlted test plugin when it is installed. It also adds using the file entitltlement as an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the plugin being testing, the entitled test plugin needs access to dynamic elements (namely, file paths). This commit dynamically generates the entitlement policy for the entitlted test plugin when it is installed. It also adds using the file entitltlement as an example.