Remove redundant numShards getter from AbstractSearchAsyncAction #121865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation of batched execution changes, remove this redundant interface. We always have other ways of getting the total shard count and even assert that they are equivalent. No need to have a redundant interface method like this around before extracting an interface from this class.
original-brownbear
added
>non-issue
:Search Foundations/Search
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
the
Team:Search Foundations
|
not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of batched execution changes, remove this redundant interface. We always have other ways of getting the total shard count and even assert that they are equivalent. No need to have a redundant interface method like this around before extracting an interface from this class.
Also, remove the exception throwing that really should be assertions if anything. There's no point to this stuff, we neither expect nor properly handle exceptions in phase constructors. IF we have a bug here in the sizes of the results structures, we'll find out soon enough anyway.