Skip to content

Conversation

@original-brownbear
Copy link
Contributor

In preparation of batched execution changes, remove this redundant interface. We always have other ways of getting the total shard count and even assert that they are equivalent. No need to have a redundant interface method like this around before extracting an interface from this class.
Also, remove the exception throwing that really should be assertions if anything. There's no point to this stuff, we neither expect nor properly handle exceptions in phase constructors. IF we have a bug here in the sizes of the results structures, we'll find out soon enough anyway.

In preparation of batched execution changes, remove this redundant interface.
We always have other ways of getting the total shard count and even assert that they
are equivalent. No need to have a redundant interface method like this around before
extracting an interface from this class.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Feb 6, 2025
@original-brownbear
Copy link
Contributor Author

not needed anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants