Fix version confusion in testHandshakeRequestFutureVersionsCompatibility
#121883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity` Today we use the ID from `Version#CURRENT` in this test, which only works if its ID is no less than that of `TranportVersion#current()`. This commit fixes the test to ensure it always picks a transport version ID that is not from the past.
DaveCTurner
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Discovered in a backport to 9.0 which adds extra validation to these versions: #121801. I already added this change to the backport to get the tests to pass, this is just adding it to |
…sCompatibility-version-confusion
DaveCTurner
added
auto-backport
|
Actually, I'm going to backport this one first rather than manually applying it to all the other backports. |
DaveCTurner
deleted the
2025/02/06/testHandshakeRequestFutureVersionsCompatibility-version-confusion
branch
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
that referenced
this pull request
Feb 6, 2025
…lity` (#121883) Today we use the ID from `Version#CURRENT` in this test, which only works if its ID is no less than that of `TranportVersion#current()`. This commit fixes the test to ensure it always picks a transport version ID that is not from the past.
DaveCTurner
added a commit
that referenced
this pull request
Feb 6, 2025
…lity` (#121883) Today we use the ID from `Version#CURRENT` in this test, which only works if its ID is no less than that of `TranportVersion#current()`. This commit fixes the test to ensure it always picks a transport version ID that is not from the past.
DaveCTurner
added a commit
that referenced
this pull request
Feb 6, 2025
…lity` (#121883) Today we use the ID from `Version#CURRENT` in this test, which only works if its ID is no less than that of `TranportVersion#current()`. This commit fixes the test to ensure it always picks a transport version ID that is not from the past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we use the ID from
Version#CURRENTin this test, which onlyworks if its ID is no less than that of
TranportVersion#current().This commit fixes the test to ensure it always picks a transport version
ID that is not from the past.