Skip to content

Enforce aggs interface #121898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Enforce aggs interface #121898

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9ce9db
enforce interface
idegtiarenko Feb 6, 2025
c0540a6
Merge branch 'main' into enforce_interface
idegtiarenko Feb 11, 2025
4239b79
declare types
idegtiarenko Feb 11, 2025
76b7e90
Merge branch 'main' into enforce_interface
idegtiarenko Feb 11, 2025
9872f1d
Merge branch 'main' into enforce_interface
idegtiarenko Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...n/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/AggregatorImplementer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,7 @@ public AggregatorImplementer(

this.init = requireStaticMethod(
declarationType,
// This should be more restrictive and require org.elasticsearch.compute.aggregation.AggregatorState
requirePrimitiveOrImplements(elements, Types.RELEASABLE),
requirePrimitiveOrImplements(elements, ClassName.get("org.elasticsearch.compute.aggregation", "AggregatorState")),
Copy link
Contributor

@ivancea ivancea Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move those to the Types constants class? To follow what we do with other types.
Same with the GroupingAggregatorState one

Copy link
Member

@nik9000 nik9000 Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

requireName("init", "initSingle"),
requireAnyArgs("<arbitrary init arguments>")
);
Expand Down
3 changes: 1 addition & 2 deletions ...ompute/gen/src/main/java/org/elasticsearch/compute/gen/GroupingAggregatorImplementer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ public GroupingAggregatorImplementer(

this.init = requireStaticMethod(
declarationType,
// This should be more restrictive and require org.elasticsearch.compute.aggregation.GroupingAggregatorState
requirePrimitiveOrImplements(elements, Types.RELEASABLE),
requirePrimitiveOrImplements(elements, ClassName.get("org.elasticsearch.compute.aggregation", "GroupingAggregatorState")),
requireName("init", "initGrouping"),
requireAnyArgs("<arbitrary init arguments>")
);
Expand Down
3 changes: 2 additions & 1 deletion ...te/src/main/generated-src/org/elasticsearch/compute/aggregation/RateDoubleAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion ...ute/src/main/generated-src/org/elasticsearch/compute/aggregation/RateFloatAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion ...mpute/src/main/generated-src/org/elasticsearch/compute/aggregation/RateIntAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion ...pute/src/main/generated-src/org/elasticsearch/compute/aggregation/RateLongAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions ...te/src/main/generated-src/org/elasticsearch/compute/aggregation/TopBooleanAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions ...e/src/main/generated-src/org/elasticsearch/compute/aggregation/TopBytesRefAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions ...ute/src/main/generated-src/org/elasticsearch/compute/aggregation/TopDoubleAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions ...pute/src/main/generated-src/org/elasticsearch/compute/aggregation/TopFloatAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions ...ompute/src/main/generated-src/org/elasticsearch/compute/aggregation/TopIntAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions ...compute/src/main/generated-src/org/elasticsearch/compute/aggregation/TopIpAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading