ES|QL: fix ENRICH validation for use of wildcards #121911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>bug
auto-backport
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
astefan
reviewed
Feb 7, 2025
| if (ne instanceof UnresolvedNamePattern || ne instanceof UnresolvedStar) { | ||
| var src = ne.source(); | ||
| throw new ParsingException(src, "Using wildcards [*] in ENRICH WITH projections is not allowed [{}]", up.pattern()); | ||
| throw new ParsingException(src, "Using wildcards [*] in ENRICH WITH projections is not allowed [{}]", src.text()); |
There was a problem hiding this comment.
Suggested change
| throw new ParsingException(src, "Using wildcards [*] in ENRICH WITH projections is not allowed [{}]", src.text()); | |
| throw new ParsingException(src, "Using wildcards [*] in ENRICH WITH projections is not allowed, found [{}]", src.text()); |
astefan
approved these changes
Feb 7, 2025
idegtiarenko
approved these changes
Feb 7, 2025
…d_validation' into esql/fix_enrich_wildcard_validation
|
Thanks folks! |
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 7, 2025
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 7, 2025
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 7, 2025
This was referenced Feb 7, 2025
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 7, 2025
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #121740
Fix validation of ENRICH with usage of (unsupported) wildcards in field names, eg.