Add 9.0 patch transport version constants #121985 #121986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transport version changes must be unique per branch. Some transport version changes meant for 9.0 are missing unique backport constants. This is a backport of elastic#121985, adding unique transport version patch numbers for each change intended for 9.0.
rjernst
added
the
auto-merge-without-approval
ldematte
reviewed
Feb 7, 2025
| public static final TransportVersion TRANSPORT_STATS_HANDLING_TIME_REQUIRED_90 = def(9_000_0_02); | ||
| public static final TransportVersion REMOVE_DESIRED_NODE_VERSION_90 = def(9_000_0_03); | ||
| public static final TransportVersion ESQL_DRIVER_TASK_DESCRIPTION_90 = def(9_000_0_04); | ||
|
|
There was a problem hiding this comment.
For a follow up: insert a comment here that versions >= 9_001_0_00 are forbidden here? So that any auto-backport breaks, and manual backports should read it (as it would be right on the conflict line?)
There was a problem hiding this comment.
There could always be a test that failed if the transport version was ever 9_001_0_00 or above
There was a problem hiding this comment.
Yes, that was what @alexey-ivanov-es proposed too. I'm going to add that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transport version changes must be unique per branch. Some transport version changes meant for 9.0 are missing unique backport constants. This is a backport of #121985, adding unique transport version patch numbers for each change intended for 9.0.