Support real-time gets on hollow shards #122012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
added
WIP
:Distributed Indexing/Engine
elasticsearchmachine
added
v9.1.0
serverless-linked
arteam
changed the title
arteam
changed the title
arteam
changed the title
kingherc
reviewed
Feb 10, 2025
server/src/main/java/org/elasticsearch/action/get/TransportGetAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/get/MultiGetShardRequest.java
Outdated
Show resolved
Hide resolved
kingherc
reviewed
Feb 10, 2025
server/src/main/java/org/elasticsearch/action/get/TransportGetFromTranslogAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/get/TransportGetAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/get/MultiGetShardResponse.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/get/MultiGetShardRequest.java
Outdated
Show resolved
Hide resolved
…tFomTranslogAction extendable" This reverts commit 3237dfa
…d didn't get a cluster update
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
elasticsearchmachine
added
the
Team:Distributed Indexing
fcofdez
reviewed
Feb 11, 2025
Contributor
fcofdez
left a comment
fcofdez
left a comment
There was a problem hiding this comment.
Looks good, I left a couple of comments
server/src/main/java/org/elasticsearch/action/get/TransportShardMultiGetAction.java
Show resolved
Hide resolved
| return threadPool.executor(executorSelector.executorForGet(shardId.getIndexName())); | ||
| } else if (indicesService.indexServiceSafe(shardId.getIndex()).getIndexSettings().isSearchThrottled()) { | ||
| } | ||
| var indexService = indicesService.indexService(shardId.getIndex()); |
Contributor
There was a problem hiding this comment.
why is this change needed?
Contributor
Author
There was a problem hiding this comment.
https://github.com/elastic/elasticsearch/pull/122012/files#r1950399319
I've seen an IndexNotFoundException being thrown here during the stress testing of real-time gets which failed the request, because we don't expect it here. Let me double check if it's still the case.
Contributor
Author
There was a problem hiding this comment.
It used to be failing with something like
Caused by: java.lang.IllegalStateException: unexpected exception processing cluster state version [112] in context [ClusterStateObserver[null]]
at org.elasticsearch.cluster.ClusterStateObserver$ObserverClusterStateListener.logUnexpectedException(ClusterStateObserver.java:317)
... 12 more
Caused by: [rjsadmjle/ScBnoey6QYqfReJ_JhmkhA] org.elasticsearch.index.IndexNotFoundException: no such index [rjsadmjle]
at org.elasticsearch.indices.IndicesService.indexServiceSafe(IndicesService.java:586)
at org.elasticsearch.action.get.TransportGetAction.getExecutor(TransportGetAction.java:169)
at org.elasticsearch.action.get.TransportGetAction.tryGetFromTranslog(TransportGetAction.java:297)
at org.elasticsearch.action.get.TransportGetAction.getFromTranslog(TransportGetAction.java:263)
at org.elasticsearch.action.get.TransportGetAction$1.onNewClusterState(TransportGetAction.java:241)
but it doesn't anymore, so I've reverted in in b965926
Contributor
There was a problem hiding this comment.
I still see the change, maybe you forgot to change this branch?
Contributor
There was a problem hiding this comment.
@arteam can we revert this change here (and in GET) if it's not needed? Before I approve.
Contributor
Author
…t node" This reverts commit ff0c191.
kingherc
reviewed
Feb 11, 2025
Contributor
kingherc
left a comment
kingherc
left a comment
There was a problem hiding this comment.
One final comment from me.
server/src/main/java/org/elasticsearch/action/get/TransportShardMultiGetAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/get/TransportShardMultiGetAction.java
Show resolved
Hide resolved
fcofdez
reviewed
Feb 11, 2025
server/src/main/java/org/elasticsearch/action/get/TransportShardMultiGetAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/get/TransportShardMultiGetAction.java
Show resolved
Hide resolved
kingherc
approved these changes
Feb 11, 2025
Contributor
kingherc
left a comment
kingherc
left a comment
There was a problem hiding this comment.
LGTM. Please ensure CI passes before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getLastUnsafeSegmentGenerationForGetsfor anyEngine, not onlyInternalEngineAlreadyClosedExceptionin case a shard's engine gets swapped.See ES-10571