Use LogsDB for profiling events to reduce storage footprint #122034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockdaboot
added
>enhancement
cloud-deploy
elasticsearchmachine
added
the
external-contributor
rockdaboot
force-pushed
the
profiling-events-logsdb
branch
from
c62bb56 to
022bae0
Compare
felixbarny
reviewed
Feb 10, 2025
There was a problem hiding this comment.
The changes look good. Before merging, we should do some tests to evaluate the impact on ingest performance. The impact may not be that high given the fact that we've already applied index sorting before.
When testing, make sure to use a recent snapshot of main, which enables synthetic recovery source by default which is a big win for ingestion performance when synthetic source is used.
.../main/java/org/elasticsearch/xpack/profiling/persistence/ProfilingIndexTemplateRegistry.java
Outdated
Show resolved
Hide resolved
|
Pinging @elastic/obs-ds-intake-services (Team:obs-ds-intake-services) |
elasticsearchmachine
added
the
Team:obs-ds-intake-services
|
Updated the description with benchmark results and marked as "ready for review". |
christos68k
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In experiments we found out that LogsDB reduces storage costs of profiling events data by ~30% in comparison to what we have today.
Keeping this in draft until benchmarks confirm that we won't have regressions in query latency or index latency.
The
cloud-deploylabel creates an artifact that can be used fur rally benchmarks or testing.Benchmark summary:
(storage costs is the greatest concern atm)