Aggs: Comment on deprecated execution mode #122046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a comment to `execution_mode: global_ordinals_hash` explaining that we're not going to remove it so we don't break anyone.
nik9000
added
:Analytics/Aggregations
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
Member
Author
|
I'm not sure why I maked this as merging without approval. I think I meant to mark it as auto-backport... |
Member
Author
|
But I think it's pretty safe. |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Feb 7, 2025
This adds a comment to `execution_mode: global_ordinals_hash` explaining that we're not going to remove it so we don't break anyone.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a comment to
execution_mode: global_ordinals_hashexplaining that we're not going to remove it so we don't break anyone.