Fork post-snapshot-delete cleanup off master thread #122047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't run the post-snapshot-delete cleanup work on the master thread, since it can be quite expensive and need not block subsequent cluster state updates. This commit forks it onto a `SNAPSHOT` thread.
DaveCTurner
added
>bug
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
DaveCTurner
added
the
auto-backport
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 7, 2025
We shouldn't run the post-snapshot-delete cleanup work on the master thread, since it can be quite expensive and need not block subsequent cluster state updates. This commit forks it onto a `SNAPSHOT` thread.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 7, 2025
We shouldn't run the post-snapshot-delete cleanup work on the master thread, since it can be quite expensive and need not block subsequent cluster state updates. This commit forks it onto a `SNAPSHOT` thread.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 7, 2025
We shouldn't run the post-snapshot-delete cleanup work on the master thread, since it can be quite expensive and need not block subsequent cluster state updates. This commit forks it onto a `SNAPSHOT` thread.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
mhl-b
added a commit
to mhl-b/elasticsearch
that referenced
this pull request
Feb 11, 2025
Merged
nicktindall
pushed a commit
that referenced
this pull request
Feb 11, 2025
mhl-b
added a commit
to mhl-b/elasticsearch
that referenced
this pull request
Feb 11, 2025
(cherry picked from commit 3ec1d12)
mhl-b
added a commit
to mhl-b/elasticsearch
that referenced
this pull request
Feb 11, 2025
(cherry picked from commit 3ec1d12)
mhl-b
added a commit
to mhl-b/elasticsearch
that referenced
this pull request
Feb 11, 2025
(cherry picked from commit 3ec1d12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't run the post-snapshot-delete cleanup work on the master
thread, since it can be quite expensive and need not block subsequent
cluster state updates. This commit forks it onto a
SNAPSHOTthread.