-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Upgrade discovery-ec2
to AWS SDK v2
#122062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade discovery-ec2
to AWS SDK v2
#122062
Conversation
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Hi @DaveCTurner, I've updated the changelog YAML for you. Note that since this PR is labelled |
Hi @DaveCTurner, I've updated the changelog YAML for you. Note that since this PR is labelled |
This reverts commit acf9c3f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @breskeby, there's a little more to discuss on this one first so I'm removing this approval for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started making my way through this, but haven't had time to come back to it yet. Posting a few comments in the meantime -- so they don't get too stale.
test/fixtures/ec2-imds-fixture/src/main/java/fixture/aws/imds/Ec2ImdsHttpFixture.java
Show resolved
Hide resolved
test/fixtures/ec2-imds-fixture/src/main/java/fixture/aws/imds/Ec2ImdsHttpFixture.java
Show resolved
Hide resolved
plugins/discovery-ec2/src/test/java/org/elasticsearch/discovery/ec2/Ec2DiscoveryTests.java
Outdated
Show resolved
Hide resolved
plugins/discovery-ec2/src/test/java/org/elasticsearch/discovery/ec2/EC2RetriesTests.java
Outdated
Show resolved
Hide resolved
plugins/discovery-ec2/src/main/java/org/elasticsearch/discovery/ec2/Ec2DiscoveryPlugin.java
Show resolved
Hide resolved
plugins/discovery-ec2/src/main/java/org/elasticsearch/discovery/ec2/Ec2NameResolver.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC we still need to add Property.Deprecated
to the discovery.ec2.protocol
Setting, but LGTM once that's sorted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
💔 Backport failed
You can use sqren/backport to manually backport by running |
Backport of elastic#122062 to 8.x
Backport is #125072 |
* Upgrade `discovery-ec2` to AWS SDK v2 Backport of #122062 to 8.x * Remove stray UpdateForV10
Left-over from elastic#122062
Left-over from elastic#122062
Left-over from elastic#122062
@DaveCTurner is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes] |
No, we do not use |
No description provided.