Skip to content

Conversation

DaveCTurner
Copy link
Contributor

No description provided.

@DaveCTurner DaveCTurner added :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure v8.19.0 v9.1.0 labels Feb 7, 2025
@DaveCTurner DaveCTurner marked this pull request as ready for review February 20, 2025 16:39
@DaveCTurner DaveCTurner requested a review from a team as a code owner February 20, 2025 16:39
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Feb 20, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've updated the changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've updated the changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

breskeby
breskeby previously approved these changes Feb 20, 2025
Copy link
Contributor

@breskeby breskeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaveCTurner DaveCTurner dismissed breskeby’s stale review February 20, 2025 16:55

Thanks @breskeby, there's a little more to discuss on this one first so I'm removing this approval for now

Copy link
Contributor

@DiannaHohensee DiannaHohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started making my way through this, but haven't had time to come back to it yet. Posting a few comments in the meantime -- so they don't get too stale.

Copy link
Contributor

@DiannaHohensee DiannaHohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC we still need to add Property.Deprecated to the discovery.ec2.protocol Setting, but LGTM once that's sorted.

Copy link
Contributor

@DiannaHohensee DiannaHohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DaveCTurner DaveCTurner added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged labels Mar 18, 2025
@elasticsearchmachine elasticsearchmachine merged commit a2d98e4 into elastic:main Mar 18, 2025
17 checks passed
@DaveCTurner DaveCTurner deleted the 2025/02/07/discovery-ec2-sdk-v2 branch March 18, 2025 08:38
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 122062

DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Mar 18, 2025
@DaveCTurner
Copy link
Contributor Author

Backport is #125072

elasticsearchmachine pushed a commit that referenced this pull request Mar 18, 2025
* Upgrade `discovery-ec2` to AWS SDK v2

Backport of #122062 to 8.x

* Remove stray UpdateForV10
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Mar 18, 2025
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 3, 2025
elasticsearchmachine pushed a commit that referenced this pull request Apr 3, 2025
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 3, 2025
elasticsearchmachine pushed a commit that referenced this pull request Apr 3, 2025
andreidan pushed a commit to andreidan/elasticsearch that referenced this pull request Apr 9, 2025
@leemthompo
Copy link
Contributor

@DaveCTurner is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes]

@DaveCTurner
Copy link
Contributor Author

No, we do not use discovery-ec2 in serverless and users wouldn't have access to it even if we did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >breaking :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure Team:Distributed Coordination Meta label for Distributed Coordination team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants