Handle rejection in DriverScheduler #122105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
fix-driver-exceptions
branch
2 times, most recently
from
264efe6 to
20904e8
Compare
dnhatn
added
v9.0.1
v8.19.0
v8.18.1
>non-issue
:Analytics/ES|QL
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
smalyshev
approved these changes
Feb 8, 2025
Member
Author
|
Thanks @smalyshev |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 8, 2025
When a node is shutting down, scheduling tasks for the Driver can result in a rejection exception. In this case, we drain and close all operators. However, we don't clear the pending tasks in the scheduler, which can lead to a pending task being triggered unexpectedly, causing a ConcurrentModificationException.
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 8, 2025
When a node is shutting down, scheduling tasks for the Driver can result in a rejection exception. In this case, we drain and close all operators. However, we don't clear the pending tasks in the scheduler, which can lead to a pending task being triggered unexpectedly, causing a ConcurrentModificationException.
Collaborator
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 8, 2025
When a node is shutting down, scheduling tasks for the Driver can result in a rejection exception. In this case, we drain and close all operators. However, we don't clear the pending tasks in the scheduler, which can lead to a pending task being triggered unexpectedly, causing a ConcurrentModificationException.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 8, 2025
When a node is shutting down, scheduling tasks for the Driver can result in a rejection exception. In this case, we drain and close all operators. However, we don't clear the pending tasks in the scheduler, which can lead to a pending task being triggered unexpectedly, causing a ConcurrentModificationException.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 8, 2025
When a node is shutting down, scheduling tasks for the Driver can result in a rejection exception. In this case, we drain and close all operators. However, we don't clear the pending tasks in the scheduler, which can lead to a pending task being triggered unexpectedly, causing a ConcurrentModificationException.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 8, 2025
When a node is shutting down, scheduling tasks for the Driver can result in a rejection exception. In this case, we drain and close all operators. However, we don't clear the pending tasks in the scheduler, which can lead to a pending task being triggered unexpectedly, causing a ConcurrentModificationException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node is shutting down, scheduling tasks for the Driver can result in a rejection exception. In this case, we drain and close all operators. However, we don't clear the pending tasks in the scheduler, which can lead to a pending task being triggered unexpectedly, causing a ConcurrentModificationException