Dry up search error trace ITs #122138
Merged
Dry up search error trace ITs #122138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This logic will need a bit of adjustment for bulk query execution. Lets dry it up before so we don't have to copy and paste the fix which will be a couple lines.
original-brownbear
added
>non-issue
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
piergm
approved these changes
Feb 10, 2025
| * Utilities around testing the `error_trace` message header in search. | ||
| */ | ||
| public enum ErrorTraceHelper { | ||
| ; |
Contributor
Author
There was a problem hiding this comment.
Can't do that :) it's the empty enum as a utility class here :D still need to delineate the absence of values.
Contributor
Author
|
Thanks Matteo! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Apr 9, 2025
This logic will need a bit of adjustment for bulk query execution. Lets dry it up before so we don't have to copy and paste the fix which will be a couple lines.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic will need a bit of adjustment for bulk query execution. Lets dry it up and expose a minimal surface before that, so we don't have to copy and paste the fix which will be a couple lines.