First last #122176
Closed
First last #122176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/planner/AggregateMapper.java
idegtiarenko
commented
Feb 13, 2025
| first_grouped | ||
| required_capability: fn_first_last | ||
| FROM sample_data | ||
| | STATS event_duration = first_value(event_duration), message = first_value(message) BY hourly = BUCKET(@timestamp, 1 hour) |
There was a problem hiding this comment.
I was hoping the function could be called first but this conflicts with nulls ordering keywords:
elasticsearch/x-pack/plugin/esql/src/main/antlr/EsqlBaseParser.g4
Lines 232 to 234 in aaa5ce8
Please let me know if it is worth to workaround it somehow (may be parsing first/last only in the sorting mode?)
Although it might not be trivial since sort uses expression mode as it is theoretically possible to:
| SORT first_value(event_duration) nulls first
|
Outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my preliminary experiment targeted implementing
first(value, @timestamp)function.This is still WIP while I am finalizing related changes.
Depends on #122174
Resolves #108385