Fix small mistake in listener wrapping in SearchService #122190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`l` is the same as the `finalListener` here, that's kind of the point of the API. Fixing this here and removing the local variable the enabled the mistake in the first place. Not a bug, but a needless capture that at times makes heap dumps harder to read and wastes a couple cycles.
original-brownbear
added
>non-issue
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
original-brownbear
added
v8.19.0
auto-backport
Contributor
Author
|
Thanks Matteo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lis the same as thefinalListenerhere, that's kind of the point of the API. Fixing this here and removing the local variable the enabled the mistake in the first place. Not a bug, but a needless capture that at times makes heap dumps harder to read and wastes a couple cycles.