Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 10, 2025

With this change, we will skip tests using semantic_texts in ES|QL while awaiting a fix for the mismatch in the _source of the semantic text fields. The key change is that we need to avoid indexing semantic_text fields in clusters with more than one node.

Relates #121411

@dnhatn dnhatn added v9.0.1 v8.19.0 v8.18.1 :Analytics/ES|QL AKA ESQL >test Issues or PRs that are addressing/adding tests labels Feb 11, 2025
@dnhatn dnhatn requested review from alex-spies and nik9000 February 11, 2025 00:40
@dnhatn dnhatn marked this pull request as ready for review February 11, 2025 00:41
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@dnhatn dnhatn added the auto-backport Automatically create backport pull requests when merged label Feb 11, 2025
@dnhatn
Copy link
Member Author

dnhatn commented Feb 11, 2025

Thanks Nik!

@dnhatn dnhatn merged commit ce9f3f4 into elastic:main Feb 11, 2025
16 of 17 checks passed
@dnhatn dnhatn deleted the skip-semantic-text branch February 11, 2025 04:35
@alex-spies
Copy link
Contributor

Thank you Nhat!

dnhatn added a commit that referenced this pull request Mar 4, 2025
This change removes the skipping introduced for the semantic_text tests 
in #122222. These tests were accidentally re-enabled without failures
over the last two weeks, so we can now re-enable them.

Closes #121411
Relates #122222
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
This change removes the skipping introduced for the semantic_text tests 
in elastic#122222. These tests were accidentally re-enabled without failures
over the last two weeks, so we can now re-enable them.

Closes elastic#121411
Relates elastic#122222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants