[Entitlements] Instrumentation for FileSystemProvider #122232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
reviewed
Feb 11, 2025
| FileAttribute<?>... attrs | ||
| ); | ||
|
|
||
| void checkNewDirectoryStream(Class<?> callerClass, FileSystemProvider that, Path dir, DirectoryStream.Filter<? super Path> filter); |
There was a problem hiding this comment.
Wow, this is a large number of special-case check methods. If we had check inheritance, would that make these unnecessary?
There was a problem hiding this comment.
Well, we will have these anyway! We would just not need the 25 lines or so in EntitlementInitialization that wire them up to the correct class, so not such a big difference.
mosche
approved these changes
Feb 12, 2025
|
|
||
| private static ElasticsearchEntitlementChecker manager; | ||
|
|
||
| interface InstrumentationInfoFunction { |
There was a problem hiding this comment.
optional nit: InstrumentationInfoFactory?
There was a problem hiding this comment.
Thanks! I always appreciate a good name suggestion :)
💔 Backport failed
You can use sqren/backport to manually backport by running |
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 12, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 13, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 13, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 13, 2025
…22232) (elastic#122471) * [Entitlements] Instrumentation for FileSystemProvider (elastic#122232) * Move some check function and tests to version specific checker classes * Refactor/fix: lookupImplementationMethod looks up the class hierarchy too * Spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds entitlement instrumentation for
FileSystemProvider; we instrument the concrete class obtained at runtime fromFileSystem.default().Relates to ES-10793