-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Entitlements] Instrumentation for FileSystemProvider #122232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ldematte
merged 13 commits into
elastic:main
from
ldematte:entitlements/file-system-provider
Feb 12, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2a1a960
NIO FileSystemProvider checks
ldematte 627c23a
Merge remote-tracking branch 'upstream/main' into entitlements/file-s…
ldematte 648a315
Use correct paths for temp files
ldematte 536d8ab
Merge remote-tracking branch 'upstream/main' into entitlements/file-s…
ldematte acc9ab6
spotless
ldematte 9bf9e1b
comment
ldematte 79eab27
Adjust exception handling
ldematte 05e218e
Add missing server entitlement
ldematte 8399edb
[CI] Auto commit changes from spotless
54b5b6b
Merge remote-tracking branch 'upstream/main' into entitlements/file-s…
ldematte 04ab43d
Renaming + flattening streams
ldematte d1a042b
Merge branch 'main' into entitlements/file-system-provider
ldematte e9dfd31
Merge remote-tracking branch 'upstream/main' into entitlements/file-s…
ldematte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is a large number of special-case check methods. If we had check inheritance, would that make these unnecessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we will have these anyway! We would just not need the 25 lines or so in
EntitlementInitializationthat wire them up to the correct class, so not such a big difference.