Ensure removal of index blocks does not leave key with null value #122246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewhiting
added
>bug
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @lukewhiting, I've created a changelog YAML for you. |
lukewhiting
added a commit
to lukewhiting/elasticsearch
that referenced
this pull request
Feb 11, 2025
…astic#122246) * ES-10801 Ensure removal of index blocks does not leave key with null value * Update docs/changelog/122246.yaml
This was referenced Feb 11, 2025
lukewhiting
added a commit
to lukewhiting/elasticsearch
that referenced
this pull request
Feb 11, 2025
…astic#122246) * ES-10801 Ensure removal of index blocks does not leave key with null value * Update docs/changelog/122246.yaml
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the copy index from source action would leave keys will null values in the index settings after overriding index read/write blocks.
This patch addresses that by ensuring such block settings are completely removed rather than just getting nulled.
Fixes ES-10801