[TEST] Handle error in concurrent downsample actions #122251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrik-es
added
>test
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Feb 12, 2025
| try { | ||
| downsample(sourceIndex, targetIndex, config); | ||
| } catch (ResourceAlreadyExistsException e) { | ||
| } catch (ElasticsearchException e) { |
There was a problem hiding this comment.
A persistent task with the same id/name should result in a ResourceAlreadyExistsException. However maybe it is wrapped in another exception and that is why the test failed. I think just catching a parent exception is ok here. We could also maybe unwrap the cause? (ExceptionsHelper)
There was a problem hiding this comment.
The log shows that actually both tasks ran, somehow.. The exception is from the second task failing to write to the target index, as it's marked as read-only by the first one after populating it. I'm not sure how it is possible to have both tasks to run, couldn't reproduce it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reported test failure indicates that there are two identical persistent tasks proceeding, which is not an issue with the downsample action (this shouldn't be happening).
Fixes #122158